turns out neovim supports lsp line diagnostics natively

lua/conf/plugins/lsp_lines.lua

@@ -1,4 +0,0 @@
-return { "whynothugo/lsp_lines",
-  url = "https://git.sr.ht/~whynothugo/lsp_lines.nvim",
-  disable = not vim.fn.has("nvim-0.8.0")
-}

lua/core/lsp/functions.lua

@@ -69,7 +69,7 @@ function M.setup()
   vim.diagnostic.config {
     virtual_text = false,
     virtual_lines = {
-      only_current_line = true
+      current_line = true
     },
     update_in_insert = false,
     underline = true,